chore(deps): bump js-yaml from 4.3.1 to 5.2.3 - #12345
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Contributor
Merge Protections🔴 1 of 6 protections blocking · waiting on 🤖 CI and 🙋 you
🔴 🤖 Continuous IntegrationWaiting for
This rule is failing.
Show 5 satisfied protections🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
Contributor
|
@dependabot[bot] this pull request is now in conflict 😩 |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/js-yaml-5.2.3
branch
from
August 10, 2026 06:27
81cfe97 to
a2a0605
Compare
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/js-yaml-5.2.3
branch
from
August 10, 2026 06:39
a2a0605 to
f7112ab
Compare
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.3.1 to 5.2.3. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@4.3.1...5.2.3) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 5.2.3 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/js-yaml-5.2.3
branch
from
August 17, 2026 06:51
f7112ab to
e659d28
Compare
Contributor
Author
|
Superseded by #12492. |
mergify Bot
pushed a commit
that referenced
this pull request
Aug 24, 2026
Supersedes #12345, which only moves the version and so is red on `build`, `lint`, `test` and `config-examples`. v5 is a breaking release and the two call sites have to move with it. `scripts/validate-config-examples.mjs` now imports js-yaml as a namespace. v5 dropped the CommonJS default export, so `import yaml from 'js-yaml'` failed to load at all. That was also behind the three test failures: `yaml` was `undefined`, `yaml.load` threw a `TypeError`, the script caught it and reported "invalid YAML", so an example that should have failed AJV schema validation failed at the parse step instead. All three pass on the import fix alone — no v5 parsing behaviour change is involved. `OptionsTable.tsx` drops `noCompatMode: true`, which v5 removed. It suppressed YAML-1.1-compat quoting of `yes`/`no`/`on`/`off` and base-60 values. None of the 136 defaults in the schema are one of those, so this is a no-op today; v5 quotes them by default and offers no way to opt out, so a future default of `no` would start rendering as `"no"`. `OptionsTable.tsx` also renames `quotingType: '"'` to `quoteStyle: 'double'`, and this is the reason the bump is not mechanical. v5 renamed that option *and* flipped its default to `'single'`, so just deleting the two options `tsc` rejects silently reflows four published defaults. The worst is `post_check.title`, whose value contains single quotes: before "'{{ check_rule_name }}'{% if check_status == 'success' %} …" after '''{{ check_rule_name }}''{% if check_status == ''success'' %} …' Equivalent YAML, unreadable in a table people copy-paste from. `@types/js-yaml` is dropped rather than bumped: v5 ships its own types, so the stub is now a mismatched duplicate. This goes to 5.3.0 rather than the 5.2.3 in #12345 because `^5.2.3` resolves to 5.3.0 anyway, and 5.3.0 only adds a custom-tag API this repo does not touch — `dump` output is byte-identical between the two. Verification: built the site on `main` and on this branch and diffed the output — all 385 pages are byte-identical, so nothing readers see moves. Every schema default also renders identically through `dumpDefault`. `pnpm check`, `pnpm test` (172), `pnpm check:config-examples` (122 examples) and `pnpm check:internal-leaks` are green, and a full build with OG generation on produces 137 cards, same as `main`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps js-yaml from 4.3.1 to 5.2.3.
Changelog
Sourced from js-yaml's changelog.
... (truncated)
Commits
67404455.2.3 released94e766dUpdate changelogc3bd7caPolish previous commit, #78000209b6presenter: treat a tab-indented line in a folded scalar as more-indented (#780)40fcb4fFix missing mapping values before document markers and reject unpaired mappin...49280f3Fix !!timestamp resolution for years 0000-0099, #775355dc96fix: prevent prototype fallback in tag and harden object lookups, #782 (than...d524f83docs: add contributing guidelines3c295595.2.2 released3e5240fparser: avoid reparsing flow sequence pair keys